Skip to content
This repository has been archived by the owner on Sep 6, 2018. It is now read-only.

Compile output files #16

Merged
merged 11 commits into from
Feb 12, 2017
Merged

Compile output files #16

merged 11 commits into from
Feb 12, 2017

Conversation

djbe
Copy link
Member

@djbe djbe commented Jan 30, 2017

Fixes #16.

TODO: find some way to test the custom imports.

@djbe
Copy link
Member Author

djbe commented Jan 30, 2017

Running this already reveals some issues with the current output:

  • Colors (rawValue): there's a value that appears twice (0xff66ccff)
  • Strings (structured/dot): there's a duplicate definition of Deeper (the case, and the sub-enum)
  • Images (dot-syntax): the struct init methods don't need to be public

@djbe djbe mentioned this pull request Jan 31, 2017
@AliSoftware AliSoftware self-assigned this Feb 12, 2017
Copy link
Collaborator

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than moving the Modules/**/*.swift and Definitions.swift files away from Scripts/, seems ok to me.

for m in ${MODULES[@]}; do
echo "Compiling module ${m}… (macos)"
xcrun $SWIFT3_TOOLCHAIN swiftc -emit-module "Scripts/Modules/$m.swift" -sdk $SDK -module-name "$m" -emit-module-path "Scripts/Modules/swift3" -target $TARGET
xcrun $SWIFT2_TOOLCHAIN swiftc -emit-module "Scripts/Modules/$m.swift" -sdk $SDK -module-name "$m" -emit-module-path "Scripts/Modules/swift2.3" -target $TARGET
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that's logical to put the Modules/*.swift files in Scripts/? Shouldn't they be considered fixtures, or fixture helpers, instead? They are not scripts after all

@AliSoftware AliSoftware merged commit 08137d9 into master Feb 12, 2017
@djbe djbe deleted the feature/compile-output branch February 12, 2017 22:49
@djbe djbe modified the milestone: 1.0.0 Feb 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants